Make explicit that auth file is not supported anymore#17395
Conversation
lmazuel
requested review from
johanste,
rakshith91 and
xiangyan99
as code owners
ghost
added
the
| """ | ||
| if _is_autorest_v3(client_class): | ||
| raise ValueError( | ||
| "Auth file or JSON dict are deprecated auth approach and are not supported anymore. " |
There was a problem hiding this comment.
This implies that these approaches are generally deprecated -- should the deprecation be specific to track 2 clients? e.g. by saying something like "azure-common factory methods are deprecated for client_class.__name__ and are not supported anymore."
There was a problem hiding this comment.
It's under a "track2" if statement, is that not enough you think?
There was a problem hiding this comment.
I think it should cover the cases where this should be raised, but I just wonder if users would be led to think that these factory methods wouldn't work for non-deprecated track 1 clients as well. Does that make sense?
There was a problem hiding this comment.
This is assuming that most users wouldn't look at the source code to notice that the error is specific to this condition
There was a problem hiding this comment.
Well, I think we don't love auth file, and therefore being sligtly wide in the message is ok to me. But this is a good point to think.
|
Seems the storage failure is not related to this PR, forcing merge |
4 participants
Fix #16791